dsmiley commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1058397971
########## solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java: ########## @@ -30,15 +35,19 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase { @BeforeClass public static void beforeClass() throws Exception { - initCore(); + solrClientTestRule + .build() + .setSolrHome(Paths.get(SolrJettyTestBase.legacyExampleCollection1SolrHome())) + .init(); } @Before @Override public void setUp() throws Exception { super.setUp(); - getSolrClient().deleteByQuery("*:*"); - getSolrClient() + solrClientTestRule.getSolrClient().deleteByQuery("*:*"); + solrClientTestRule + .getSolrClient() Review Comment: > Should I define getSolrClient() in EmbeddedSolrServerTestBase to return the client created in the test rule Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org