dsmiley commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1060083238
########## solr/core/src/test-files/solr/solr.xml: ########## @@ -35,11 +35,6 @@ <int name="connTimeout">${connTimeout:15000}</int> </shardHandlerFactory> - <transientCoreCacheFactory name="transientCoreCacheFactory" class="TransientSolrCoreCacheFactoryDefault"> Review Comment: `<coreManager>` works for me because its a reasonable name today and in the future if this class takes on core creation responsibility. > The ticket doesn't even say that you are introducing a new type of component , what the configuration looks like or what the responsibilities are for that component type From the JIRA issue: "This proposal would make SolrCores itself pluggable". So there is no new type of component, and no change of responsibilities. Yeah I could have shared what the plug-ability looks like. I'm thinking this is so expert that we shouldn't really say anything about it in the ref guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org