[GitHub] [solr] janhoy commented on a diff in pull request #1225: SOLR-9509 Fix problems reported by shellcheck

[GitBox]

janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1063389460


##########
solr/bin/solr:
##########
@@ -2153,16 +2160,17 @@ function start_solr() {
   SOLR_JETTY_ADDL_CONFIG="$3"
 
   # define default GC_TUNE
-  if [ -z ${GC_TUNE+x} ]; then # I think this check is backwards?
-      GC_TUNE=('-XX:+UseG1GC' \
+  if [ -z "${GC_TUNE}" ]; then
+      GC_TUNE_ARR=('-XX:+UseG1GC' \

Review Comment:
   I tested this
   ```bash
   $ unset GC_TUNE  
   $ if [ -z "${GC_TUNE}" ]; then                                               
                                               1 ↵  10130  13:11:57
     echo "DEFAULTS"
   else
     echo "OVERRIDE"
   fi
   DEFAULTS
   
   $ GC_TUNE=foo
   $ if [ -z "${GC_TUNE}" ]; then                                               
                                                 ✔  10128  13:11:28
     echo "DEFAULTS"
   else
     echo "OVERRIDE"
   fi
   OVERRIDE
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org