risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1064168758
##########
solr/core/src/test/org/apache/solr/core/TestConfigSetService.java:
##########
@@ -77,24 +72,31 @@ public void testConfigSetServiceOperations() throws
IOException {
byte[] testdata = "test data".getBytes(StandardCharsets.UTF_8);
Path configDir = createTempDir("testconfig");
- Files.createFile(configDir.resolve("solrconfig.xml"));
- Files.write(configDir.resolve("file1"), testdata);
- Files.createFile(configDir.resolve("file2"));
- Files.createDirectory(configDir.resolve("subdir"));
- Files.createFile(configDir.resolve("subdir").resolve("file3"));
+ String solrConfigXml = "solrconfig.xml";
+ Files.createFile(configDir.resolve(solrConfigXml));
+ String file1 = "file1";
+ Files.write(configDir.resolve(file1), testdata);
+ String file2 = "file2";
+ Files.createFile(configDir.resolve(file2));
+ String subDirPath = "subdir";
+ String subdir = subDirPath + "/";
+ Files.createDirectory(configDir.resolve(subDirPath));
+ String file3 = subdir + "file3";
+ Files.createFile(configDir.resolve(subDirPath).resolve("file3"));
+ String file4 = subdir + "file4";
Review Comment:
yea I'll clean this up. I'm not really a fan of how it turned out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
