epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096789163
##########
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##########
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTestBase {
@Test
public void testMultiThreaded() throws Exception {
- SolrClient client = this.getSolrClient();
+ SolrClient client = getSolrClient();
Review Comment:
Should this be `solrClientTestRule.getSolrClient()` ? When do we want to
use the explicit `solrClientTestRule` and when do we have a helper like
`getSolrClient()`. In some ways, I like the explicit verbosity of the
`solrClientTestRule.getSolrClient()` telling me where the client came from...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
