epugh commented on code in PR #2103: URL: https://github.com/apache/solr/pull/2103#discussion_r1412034491
########## solr/core/src/java/org/apache/solr/response/DocsStreamer.java: ########## @@ -221,6 +222,7 @@ public static Object getValue(SchemaField sf, IndexableField f) { KNOWN_TYPES.add(LongPointField.class); KNOWN_TYPES.add(DoublePointField.class); KNOWN_TYPES.add(FloatPointField.class); + KNOWN_TYPES.add(DenseVectorField.class); // DenseVectorField extends FloatPointField Review Comment: Maybe something like " // List DenseVectorField explicit due use of KNOWN_TYPES.contains instead of instaceof for performance reasons"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org