dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1915447012
@uschindler See [getDocListNC](https://github.com/apache/solr/blob/326afddeddaa2092086e6f6b27f8bc35bf6d79cf/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L1812) which already seems to be pretty well optimized when `lastDocRequested <= 0` (i.e. `rows==0`), and in conjunction also when `!needScores`. The reason some of the Lucene convenience collectors & IndexSearcher.count aren't used is because this code is juggling a multitude of scenarios, such as when there might be a so-called `PostFilter`, thus leading to another Collector to add to the head of the collectors. Care must be taken before adding yet another optimization -- does it *actually* add value or it just to feel good to use another Lucene class. `getDocListAndSetNC` follows this method and is similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
