[
https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075152#comment-15075152
]
ASF GitHub Bot commented on TS-3478:
------------------------------------
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48613347
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field)
}
MIMEField *new_field = _mhdr->field_create(name, name_len);
+ new_field->name_set(_mhdr->m_heap, _mhdr->m_mime, name, name_len);
new_field->value_set(_mhdr->m_heap, _mhdr->m_mime, value, value_len);
+ mime_hdr_field_attach(_mhdr->m_mime, new_field, 1, NULL);
--- End diff --
Why don't you use `MIMEHdr::field_attach`? It's inconsistent to use the
function here.
> Indexing header representations on HPACK encoder
> ------------------------------------------------
>
> Key: TS-3478
> URL: https://issues.apache.org/jira/browse/TS-3478
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Ryo Okubo
> Assignee: Ryo Okubo
> Labels: review
> Fix For: 6.1.0
>
> Attachments: indexing.patch
>
>
> Support other header field representations on HPACK encoder.
> http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6
> Currently the encoder supports only [Literal Header Field never
> Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
