On Fri, 17 Mar 2023 20:31:27 GMT, Andy Goryachev <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust CF test to read in with UTF-8 to fix failing test
>
> make/jdk/src/classes/build/tools/compileproperties/CompileProperties.java
> line 226:
>
>> 224: Properties p = new Properties();
>> 225: try {
>> 226: FileInputStream input = new FileInputStream(propertiesPath);
>
> Should this stream be closed in a finally { } block?
or better be `try-with-resources`?
-------------
PR: https://git.openjdk.org/jdk/pull/12726
