[JIRA] (JENKINS-13829) Race condition in Queue.pop()

[scm_issue_l...@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-13829 Race condition in Queue.pop() Code changed in jenkins User: Brad Larson Path: gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/6e9bfee152a01c8a012fba0c54e4990e746b0c2b Log: Fix behavior of canceling old patch sets There were several problems with canceling jobs created by old patch sets when new patch sets are uploaded. We were removing old jobs when scheduled() was called, but then removed() was also called, which would cancel the newly-added build we care about. Instead, we now store the PatchsetCreated event to track the jobs, and cancel all jobs for a particular Change # when a new patch set is uploaded but only remove the exact job when remove() is called. There was also a problem in calling Future.cancel(), as documented in https://issues.jenkins-ci.org/browse/JENKINS-13829. This was worked around by storing the parameters used to create each build and canceling jobs with the same parameters. This is more in-line with how jobs are canceled from the Web UI.

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira