[JIRA] (JENKINS-16606) Uncached checks of Stapler.openResourcePathByLocale for non-resources

Fri, 01 Feb 2013 14:52:58 -0800

Issue Type: Bug Bug
Assignee: Unassigned
Components: core
Created: 01/Feb/13 10:52 PM
Description:

A thread dump showed many HTTP threads doing something like this:

"Handling POST /job/.../ajaxExecutors : ...
   java.lang.Thread.State: RUNNABLE
	at java.io.UnixFileSystem.getBooleanAttributes0(Native Method)
	at java.io.UnixFileSystem.getBooleanAttributes(UnixFileSystem.java:242)
	at java.io.File.exists(File.java:772)
	at org.apache.naming.resources.FileDirContext.file(FileDirContext.java:785)
	at org.apache.naming.resources.FileDirContext.lookup(FileDirContext.java:206)
	at org.apache.naming.resources.ProxyDirContext.lookup(ProxyDirContext.java:299)
	at org.apache.catalina.core.ApplicationContext.getResource(ApplicationContext.java:495)
	at org.apache.catalina.core.ApplicationContextFacade.getResource(ApplicationContextFacade.java:176)
	at org.kohsuke.stapler.Stapler.openResourcePathByLocale(Stapler.java:207)
	at org.kohsuke.stapler.Stapler.service(Stapler.java:147)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)


If the container's implementation of ServletContext.getResource is slow to return a negative result, as it seems Tomcat's is, we waste a considerable amount of time (and disk I/O) looking for files which clearly do not exist before serving a request from the Stapler model. Probably if this method once returns null it is safe to assume it will continue to do so for the rest of the session.
Project: Jenkins
Labels: stapler performance
Priority: Major Major
Reporter: Jesse Glick
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to