[JIRA] (JENKINS-13742) Field validation does not pass required query parameters when some fields are specified in a nested Describable

[scm_issue_l...@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-13742 Field validation does not pass required query parameters when some fields are specified in a nested Describable Code changed in jenkins User: John McNally Path: src/main/java/com/collabnet/ce/webservices/CTFProject.java src/main/java/com/collabnet/ce/webservices/CollabNetApp.java src/main/java/hudson/plugins/collabnet/ConnectionFactory.java src/main/java/hudson/plugins/collabnet/auth/CNAuthProjectProperty.java src/main/java/hudson/plugins/collabnet/browser/TeamForge.java src/main/java/hudson/plugins/collabnet/tracker/CNTracker.java src/main/java/hudson/plugins/collabnet/util/CNFormFieldValidator.java src/main/java/hudson/plugins/collabnet/util/ComboBoxUpdater.java http://jenkins-ci.org/commit/collabnet-plugin/028c3cf91ffa39a544f98cb287d9554beead76e1 Log: JENKINS-13742 Field validation does not pass required query parameters when some fields are specified in a nested Describable On branch master Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout – <file>..." to discard changes in working directory) src/main/java/com/collabnet/ce/webservices/CTFProject.java (getOrCreateDocumentFolder, verifyPath): strip file separators from beginning and end of path src/main/java/com/collabnet/ce/webservices/CollabNetApp.java (fromStapler): renamed overrideAuth to connectionFactory, the former is more descriptive, but the checkbox takes the name of the composite field. Added RelativeParameter annotations to the other arguments. Also the password field may contain the encrypted form, so using Secret to transform into plaintext. src/main/java/hudson/plugins/collabnet/ConnectionFactory.java Add a fromStapler method so this can be used in validations that are internal to the composite field, such as the modified doCheckPassword method. src/main/java/hudson/plugins/collabnet/auth/CNAuthProjectProperty.java (doFillProjectItems): simplified by using getProjectList method. src/main/java/hudson/plugins/collabnet/browser/TeamForge.java (doFillProjectItems, doFillRepoItems): Added code to logoff the CTF session src/main/java/hudson/plugins/collabnet/tracker/CNTracker.java (doFillTrackerItems): Add a null check to avoid NPE, if auth data is not found src/main/java/hudson/plugins/collabnet/util/CNFormFieldValidator.java Several methods are modified to add null checks for the CollabNetAuth arg and to ensure the session is logged off. Prior to this change some methods did one and others did the other and some did neither. src/main/java/hudson/plugins/collabnet/util/ComboBoxUpdater.java (getUsers): Add null check on CollabNetApp arg

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.