|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
I have no issue with you using a snapshot. Your report has helped me confirm where the issue lies so there's been no issue with you reporting against a snapshot version. The change has been caused by the abstraction of functionality to support CVS projectets and the subsequent change to the Cvs Tagging code to change fields from being defined as concrete type to an abstract type. Any builds that have been performed with the plugin since this change are ok since serialization saves a record of what the actual type is (CVSSCM or CvsProjectset) but builds completed before this change assume they should create an exact instance of the field type which isn't possible since they type isn't a concrete class.
The big issue is how to fix this. One option is to leave functionality as it currently is knowing old builds fail whilst loading tagging (although also possibly add some code to remove the failed data from the config so the error doesn't happen every time Jenkins restarts). The second option is to revert the change to the field type with additional code to dynamically upgrade to a differently named abstract field as each build is loaded. This will cause anyone using CvsProjectset to get this error for builds performed before a release of the plugin with the fix. My personal preference would be to break functionality for CvsProjectset users since this should have far fewer completed builds to error out on, although arguably these builds are newer than any that may be recovered by fixing this for older builds.
For those of you watching this issue, do you have any thoughts or preference on this?
For reference, the problem line of code is: https://github.com/jenkinsci/cvs-plugin/blob/master/src/main/java/hudson/scm/cvstagging/CvsTagAction.java#L52