[JIRA] [core] (JENKINS-21930) Jobs fail due to "node went offline during the build"

Mon, 07 Jul 2014 09:41:28 -0700

I didn't try that, but I just looked at the source code, and found this:

https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/AbstractBuild.java#L538

public Result run(@Nonnull BuildListener listener) throws Exception {
            ....
            Computer c = node.toComputer();
            if (c==null || c.isOffline()) {
                // As can be seen in HUDSON-5073, when a build fails because of the slave connectivity problem,
                // error message doesn't point users to the slave. So let's do it here.
                listener.hyperlink("/computer/"+builtOn+"/log","Looks like the node went offline during the build. Check the slave log for the details.");
            ...


And the isOffline() method also checks for the temporarilyOffline status:

https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Computer.java#L507




public boolean isOffline() {
        return temporarilyOffline || getChannel()==null;
    }





So, you are correct, the connection is not broken, but the check in this case is wrong. It should check only for the channel, and not the temporarilyOffline status.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to