|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
@James: So I think the closed channel exception is actually closer to the Jenkins-22932 bug (if so you should repopen, since I had reopened before realizing I had a different root cause I then closed). However one could argue that the "selector" loop should actually catch all NIO errors and try again instead of it's current behavior of killing the loop entirely so it might be the case that the fix ends up being the same.
Additionally I've implemented a patch that implements the key.isValid() check above:
https://github.com/kbrowder/remoting/commit/d52cef17a789bac0d1478c561c6696a82eb9ab6a
Additionally I've got another change that captures CancelledKeyExceptions:
https://github.com/kbrowder/remoting/commit/1dc29075e26c382b593d189a3a04cd1ab859f7c5
Actually I think with some minor modification you could extend this last approach to catch a number of potential pitfalls