![]() |
|
|
|
|
Issue Type:
|
![Bug]() Bug
|
|
Affects Versions:
|
current |
|
Assignee:
|
Daniel Spilker
|
|
Components:
|
job-dsl-plugin |
|
Created:
|
29/Aug/14 1:42 PM
|
|
Description:
|
The job-dsl run-condition-plugin support is incomplete as AlwaysRun and NeverRun are not supported by SimpleCondition. At present javaposse.jobdsl.dsl.helpers.step.condition.SimpleCondition assumes that condition classes end in Condition. However the AlwaysRun and NeverRun conditions do not require the Condition suffix.
Existing code
String getConditionClass() {
"org.jenkins_ci.plugins.run_condition.${subPackage}.${name}Condition"
}
One possible solution
String getConditionClass() {
if (name.endsWith("Run")) {
return "org.jenkins_ci.plugins.run_condition.${subPackage}.${name}"
}
else {
return "org.jenkins_ci.plugins.run_condition.${subPackage}.${name}Condition"
}
}
|
|
Project:
|
Jenkins
|
|
Labels:
|
plugin
|
|
Priority:
|
![Minor]() Minor
|
|
Reporter:
|
Roy Whytock
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit
https://groups.google.com/d/optout.
