mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r908926903
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/SessionStoreBuilder.java:
##########
@@ -52,6 +53,16 @@ private SessionStore<Bytes, byte[]> maybeWrapCaching(final
SessionStore<Bytes, b
if (!enableCaching) {
return inner;
}
+
+ if (!inner.persistent()) {
Review Comment:
If we strip the caching, this applies to eager emitting, right? -- So it
would be a behavioral change? Do we want to piggy-back such a change into this
KIP? Sounds "risky"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
