showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1034451061


##########
clients/src/main/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignor.java:
##########
@@ -84,6 +84,11 @@ public ByteBuffer subscriptionUserData(Set<String> topics) {
 
     @Override
     protected MemberData memberData(Subscription subscription) {
+        // In ConsumerProtocolSubscription v2 or higher, we can take member 
data from fields directly
+        if (subscription.generationId().isPresent()) {
+            return new MemberData(subscription.ownedPartitions(), 
subscription.generationId());
+        }

Review Comment:
   In cooperativeStickyAssignor, we can directly adopt the new generation 
fields if existed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to