[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

[via GitHub]

Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132780881


##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -971,8 +971,11 @@ private[group] class GroupCoordinator(
       if (validationErrorOpt.isDefined) {
         responseCallback(offsetMetadata.map { case (k, _) => k -> 
validationErrorOpt.get })
       } else {
-        groupManager.storeOffsets(group, memberId, offsetMetadata, 
responseCallback, producerId,
-          producerEpoch, requestLocal)
+        val offsets = offsetMetadata.map { case(k,v) => new 
TopicIdPartition(Uuid.ZERO_UUID, k) -> v }

Review Comment:
   Please note that the signature of the offset commits for transactions is not 
changed, hence these conversions. It is possible to increase the scope to cover 
transaction commit offsets but erring on the side of caution here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org