Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134008996
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##########
@@ -649,26 +649,27 @@ private[group] class GroupMetadata(val groupId: String,
initialState: GroupState
}
}
- def failPendingOffsetWrite(topicPartition: TopicPartition, offset:
OffsetAndMetadata): Unit = {
+ def failPendingOffsetWrite(topicIdPartition: TopicIdPartition, offset:
OffsetAndMetadata): Unit = {
+ val topicPartition = topicIdPartition.topicPartition
pendingOffsetCommits.get(topicPartition) match {
case Some(pendingOffset) if offset == pendingOffset =>
pendingOffsetCommits.remove(topicPartition)
case _ =>
}
}
- def prepareOffsetCommit(offsets: Map[TopicPartition, OffsetAndMetadata]):
Unit = {
+ def prepareOffsetCommit(offsets: Map[TopicIdPartition, OffsetAndMetadata]):
Unit = {
receivedConsumerOffsetCommits = true
- pendingOffsetCommits ++= offsets
+ pendingOffsetCommits ++= offsets.map { case(k, v) => k.topicPartition -> v
}
Review Comment:
That makes sense, I suppose this is avoidable GC activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
