C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149841456
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/ConfigPropertyFilter.java:
##########
@@ -25,8 +25,19 @@
@InterfaceStability.Evolving
public interface ConfigPropertyFilter extends Configurable, AutoCloseable {
+ /**
+ * Specifies whether to replicate the given topic configuration whether it
has a default value or not.
+ * The configurations with default values are controlled by
shouldReplicateSourceDefault.
Review Comment:
1. This still needs to be updated if we make `shouldReplicateConfigProperty`
and `shouldReplicateSourceDefault` handle distinct properties
2. We can tidy up the Javadocs a bit by including a link to the relevant
method
```suggestion
* Specifies whether to replicate the given topic configuration whether
it has a default value or not.
* The configurations with default values are controlled by {@link
#shouldReplicateSourceDefault(String)}.
```
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java:
##########
@@ -60,6 +65,11 @@ public boolean shouldReplicateConfigProperty(String prop) {
return !excluded(prop);
}
+ @Override
+ public boolean shouldReplicateSourceDefault(String prop) {
+ return useDefaultsFrom.equals("source");
Review Comment:
(Depends on discussion on a different thread but for now I still believe
this part needs to be changed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
