viktorsomogyi commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1578650158
I had a short chat with @urbandan yesterday to understand the scope of this fix. During the conversation we came to the conclusion that bumping the epoch without a safety check is generally unsafe as there might be requests in the queue that are timed out with request timeout yet successfully appended on the broker and still wait in the queue in the producer for a retry while their epoch is being bumped. While this PR fixes once case, It would be good to review all usages where the epoch is being bumped. I don't insist on redoing all the other cases, so let me know Daniel if you want to expand the scope of this or do it in a follow up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
