[GitHub] [kafka] rondagostino commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

[via GitHub]

rondagostino commented on code in PR #13917:
URL: https://github.com/apache/kafka/pull/13917#discussion_r1242428311


##########
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##########
@@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path 
target, boolean need
         } catch (IOException outer) {
             try {
                 Files.move(source, target, 
StandardCopyOption.REPLACE_EXISTING);
-                log.debug("Non-atomic move of {} to {} succeeded after atomic 
move failed due to {}", source, target,
+                log.warn("Non-atomic move of {} to {} succeeded after atomic 
move failed due to {}", source, target,

Review Comment:
   Any maybe we should log something above the retry saying we are going to 
retry?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org