jsancio commented on code in PR #13917:
URL: https://github.com/apache/kafka/pull/13917#discussion_r1242429861
##########
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##########
@@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path
target, boolean need
} catch (IOException outer) {
try {
Files.move(source, target,
StandardCopyOption.REPLACE_EXISTING);
- log.debug("Non-atomic move of {} to {} succeeded after atomic
move failed due to {}", source, target,
+ log.warn("Non-atomic move of {} to {} succeeded after atomic
move failed due to {}", source, target,
Review Comment:
Hmm. Log levels are hard to argue. To me, it is really bad if a `move` fails
and Kafka falls back to `copy`.
There is a lot of code like the `Snaphsot.freeze` that assume `move`
semantic for correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
