hudeqi commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1263593759
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java:
##########
@@ -70,4 +91,9 @@ public Thread newThread(Runnable r) {
}
}
+
+ public void removeMetrics() {
Review Comment:
Hi, I am planning to clean up all the leaked metrics in the current base
code recently, so I will pay close attention to the "metric", Is it possible to
follow this template [here](https://github.com/apache/kafka/pull/13962)? It is
better to put the metric name in a collection to prevent others from forgetting
to remove when adding a new metric. Otherwise, my work in metric cleaning this
area may be endless. @abhijeetk88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
