lianetm commented on code in PR #14308:
URL: https://github.com/apache/kafka/pull/14308#discussion_r1311839169
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -132,4 +138,12 @@ private boolean process(final
AssignmentChangeApplicationEvent event) {
manager.maybeAutoCommit(event.offsets);
return true;
}
+
+ private boolean process(final ListOffsetsApplicationEvent event) {
+ final CompletableFuture<Map<TopicPartition, OffsetAndTimestamp>>
future =
+
requestManagers.offsetsRequestManager.fetchOffsets(event.timestampsToSearch(),
+ event.requireTimestamps());
+ event.chain(future);
Review Comment:
Sure, done.
Side note, `CommitApplicationEvent` will also use the `event.chain` but that
requires bigger changes on the `CommitRequestManager`, so leaving it for
another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
