lianetm commented on code in PR #14308:
URL: https://github.com/apache/kafka/pull/14308#discussion_r1311863608
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##########
@@ -129,6 +132,14 @@ public boolean add(final ApplicationEvent event) {
return applicationEventQueue.add(event);
}
+ @Override
Review Comment:
Yes, to avoid a cyclic dependency between our changes (integration branch
nightmare). This `addAndGet` was included in the PR for
[KAFKA-15188](https://issues.apache.org/jira/browse/KAFKA-15188) with more
implementation for the PrototypeAsyncConsumer API, that you noted depends on
this one.
Should be the cleanest way to unblock, without having to manually revert
changes here as an intermediate step. Let me know if there are any concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
