[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

[via GitHub]

lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1337278130


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##########
@@ -59,4 +59,20 @@ public interface MembershipManager {
      * current assignment.
      */
     void updateAssignment(ConsumerGroupHeartbeatResponseData.Assignment 
assignment);
+
+    /**
+     * Transition the member to the FENCED state.  This is only invoked when 
the heartbeat returns a

Review Comment:
   Extra space after state.



##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##########
@@ -59,4 +59,20 @@ public interface MembershipManager {
      * current assignment.
      */
     void updateAssignment(ConsumerGroupHeartbeatResponseData.Assignment 
assignment);
+
+    /**
+     * Transition the member to the FENCED state.  This is only invoked when 
the heartbeat returns a
+     * FENCED_MEMBER_EPOCH or UNKNOWN_MEMBER_ID error code.
+     */
+    void fenceMember();
+
+    /**
+     * Transition the member to the FAILED state.  This is invoked when the 
heartbeat returns a non-retriable error.

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org