[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

[via GitHub]

lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1337295428


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -173,24 +194,22 @@ public void testHeartbeatResponseOnErrorHandling(final 
Errors error, final boole
         heartbeatRequestState = new 
HeartbeatRequestManager.HeartbeatRequestState(
             mockLogContext,
             mockTime,
-            heartbeatInterval,
+            heartbeatIntervalMs,
             retryBackoffMs,
             retryBackoffMaxMs,
             0);
-        when(mockMembershipManager.state()).thenReturn(STABLE);
         heartbeatRequestManager = createManager();
 
-        // Sending first heartbeat to set the state to STABLE
+        // Sending first heartbeat w/o assignment to set the state to STABLE
         ConsumerGroupHeartbeatResponse rs1 = new 
ConsumerGroupHeartbeatResponse(new ConsumerGroupHeartbeatResponseData()
-            .setHeartbeatIntervalMs(heartbeatInterval)
+            .setHeartbeatIntervalMs(heartbeatIntervalMs)
             .setMemberId(memberId)
-            .setMemberEpoch(memberEpoch)
-            .setAssignment(memberAssignment));

Review Comment:
   seems we're not using `memberAssignment` in the test anymore? let's remove 
if unused



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org