lianetm commented on PR #14364: URL: https://github.com/apache/kafka/pull/14364#issuecomment-1735694640
Thanks for the changes @philipnee, left a few other minor comments and questions. LGTM. As I see it, the main areas requiring follow-up in other PRs would be: - fully integrate with the state defined in the membershipManager (getting rid of all the parallel `groupState` defined here) - integrate with the assignment processing component, driving the logic to delegate callback execution and send HB on completion as required. - extend HB manager test to cover successful path and timeout scenarios. @dajac it would be helpful if you can take another look at it now, as it has evolved quite a bit. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
