kirktrue commented on code in PR #14432:
URL: https://github.com/apache/kafka/pull/14432#discussion_r1344754813
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -593,6 +609,9 @@ private void throwIfConsumerGroupHeartbeatRequestIsInvalid(
if (request.subscribedTopicNames() == null ||
request.subscribedTopicNames().isEmpty()) {
throw new InvalidRequestException("SubscribedTopicNames must
be set in first request.");
}
+ } else if (request.memberEpoch() == -2) {
+ throwIfEmptyString(request.memberId(), "MemberId can't be empty.");
Review Comment:
It's just my preference, so if there's precedent for how you have it, I
wouldn't hold up this PR in an effort to change the other places. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
