xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1375083080
##########
build.gradle:
##########
@@ -1342,6 +1348,14 @@ project(':clients') {
implementation libs.lz4
implementation libs.snappy
implementation libs.slf4jApi
+ implementation libs.opentelemetryProto
+
+ // declare runtime libraries
Review Comment:
can we add a comment to explain which dependencies should be declared here?
##########
build.gradle:
##########
@@ -1342,6 +1348,14 @@ project(':clients') {
implementation libs.lz4
implementation libs.snappy
implementation libs.slf4jApi
+ implementation libs.opentelemetryProto
+
+ // declare runtime libraries
Review Comment:
can we add a comment to explain which dependencies should be declared here
and why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
