lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1409556622
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -531,7 +537,13 @@ private CompletableFuture<Void>
invokeOnPartitionsRevokedOrLostToReleaseAssignme
* request is sent out with it.
*/
private void transitionToSendingLeaveGroup() {
- memberEpoch = ConsumerGroupHeartbeatRequest.LEAVE_GROUP_MEMBER_EPOCH;
+ if (state == MemberState.FATAL) {
+ log.warn("Member won't send leave group request because it is in
FATAL state");
Review Comment:
Added them both. I'm also not sure that the epoch will be very helpful in
this terminal state, but I say we add it, it won't hurt and it might help to
understand the evolution with previous logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
