soarez commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414257022
##########
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##########
@@ -61,6 +67,11 @@ static class BrokerHeartbeatState {
*/
private final int id;
+ /**
+ * The directories which the broker currently has available.
+ */
+ private final List<Uuid> directories;
Review Comment:
The point was to use binary search for lookups, see `DirectoryId.isOnline`.
Since we don't expect a large list of directories, it may be ok to always to a
O(N) search. We can come back to this in the future if it proves to be an
issue. I'll change it to avoid any sorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
