cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1414705968
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -284,7 +286,7 @@ ReplicaPlacer replicaPlacer() {
public void activate() {
heartbeatManager = new BrokerHeartbeatManager(logContext, time,
sessionTimeoutNs);
for (BrokerRegistration registration : brokerRegistrations.values()) {
- heartbeatManager.touch(registration.id(), registration.fenced(),
-1);
+ heartbeatManager.register(registration.id(),
registration.fenced(), registration.directories());
Review Comment:
I don't see why we need to handle directories in `HeartbeatManager`. I made
this comment in the other PR too. HBM is about timing out brokers. It's not
about JBOD stuff really.
Directories are hard state so they should be kept in
`ClusterControlManager`. And we need to issue a new `BrokerRegistrationRecord`
when they change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
