cadonna commented on code in PR #14879:
URL: https://github.com/apache/kafka/pull/14879#discussion_r1415421728
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -232,6 +235,16 @@ private void onResponse(final
ConsumerGroupHeartbeatResponse response, long curr
this.heartbeatRequestState.onSuccessfulAttempt(currentTimeMs);
this.heartbeatRequestState.resetTimer();
this.membershipManager.onHeartbeatResponseReceived(response.data());
+ if (previousGroupMetadataUdateEvent == null ||
+ previousGroupMetadataUdateEvent.memberEpoch() !=
membershipManager.memberEpoch()) {
+
+ final GroupMetadataUpdateEvent currentGroupMetadataUpdateEvent
= new GroupMetadataUpdateEvent(
+ membershipManager.memberEpoch(),
+ previousGroupMetadataUdateEvent == null ?
membershipManager.memberId() : previousGroupMetadataUdateEvent.memberId()
+ );
+
this.backgroundEventHandler.add(currentGroupMetadataUpdateEvent);
+ previousGroupMetadataUdateEvent =
currentGroupMetadataUpdateEvent;
+ }
Review Comment:
I think you are right! Let me change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
