rondagostino commented on code in PR #14902:
URL: https://github.com/apache/kafka/pull/14902#discussion_r1420510232
##########
metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java:
##########
@@ -159,7 +159,7 @@ public static Optional<Long> zkBrokerEpoch(long value) {
private final boolean fenced;
private final boolean inControlledShutdown;
private final boolean isMigratingZkBroker;
- private final List<Uuid> sortedDirectories;
+ private final List<Uuid> directories;
Review Comment:
Not sure why we reverted this name change. I thought it was good
documentation -- this list is sorted. I guess the one reason for it is that
this field is only written to in the private constructor, so there's no
possibility of getting it wrong, and there is a desire to have the getter match
the field name. So I guess I'm okay with this revert. Maybe add a comment?
So something like this, perhaps? `private final List<Uuid> directories; // this
list will be sorted by the builder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
