rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1446822116
##########
clients/src/main/java/org/apache/kafka/common/requests/ListGroupsRequest.java:
##########
@@ -50,6 +50,10 @@ public ListGroupsRequest build(short version) {
throw new UnsupportedVersionException("The broker only
supports ListGroups " +
"v" + version + ", but we need v4 or newer to request
groups by states.");
}
+ if (!data.typesFilter().isEmpty() && version < 5) {
+ throw new UnsupportedVersionException("The broker only
supports ListGroups " +
+ "v" + version + ", but we need v5 or newer to request
groups by type.");
+ }
Review Comment:
Oh yes! Thanks for noticing this, I missed this test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
