apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459350997
########## server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java: ########## @@ -919,4 +922,101 @@ public void testPushTelemetryConcurrentRequestAfterSubscriptionUpdate() throws U // 1 request should fail with throttling error. assertEquals(1, throttlingErrorCount); } + + @Test + public void testCacheEviction() throws UnknownHostException, InterruptedException { + Properties properties = new Properties(); + properties.put("metrics", ClientMetricsConfigs.ALL_SUBSCRIBED_METRICS_CONFIG); + properties.put(ClientMetricsConfigs.PUSH_INTERVAL_MS, "100"); + clientMetricsManager.updateSubscription("sub-1", properties); + + GetTelemetrySubscriptionsRequest request = new GetTelemetrySubscriptionsRequest.Builder( + new GetTelemetrySubscriptionsRequestData(), true).build(); + + GetTelemetrySubscriptionsResponse response = clientMetricsManager.processGetTelemetrySubscriptionRequest( + request, ClientMetricsTestUtils.requestContext()); + assertEquals(Errors.NONE, response.error()); + + assertNotNull(clientMetricsManager.clientInstance(response.data().clientInstanceId())); + assertEquals(1, clientMetricsManager.expirationTimer().size()); + // Advance the clock to trigger cache eviction, cache expiry should be 100 * 3 = 300 ms. + clientMetricsManager.expirationTimer().advanceClock(300); + assertTimeoutPreemptively(Duration.ofMillis(300), () -> { Review Comment: I ran the test with @RepeatedTest for 500 times and it didn't fail for single time. The reason is that advance clock is blocking and then additional 300ms is there to complete 200 ms of tick time in hashed wheel timer. So there is a buffer of 100ms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org