dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1475831326
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1794,6 +1822,10 @@ public void onLoaded() {
". Rebalancing in order to give a chance for
consumers to commit offsets");
}
break;
+
+ default:
+ log.warn("Loaded group {} with an unknown group type {}. "
+ groupId, group.type());
Review Comment:
nit: Same comment.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -701,6 +726,9 @@ private void removeGroup(
ClassicGroup classicGroup = (ClassicGroup) group;
metrics.onClassicGroupStateTransition(classicGroup.currentState(), null);
break;
+ default:
+ log.warn("Removed group {} with an unknown group type {}.
" + groupId, group.type());
Review Comment:
nit: There is an extra space after the `.` and the `+` must be replaced by a
`,`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
