mimaison commented on code in PR #16193:
URL: https://github.com/apache/kafka/pull/16193#discussion_r1629709460


##########
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##########
@@ -728,20 +725,14 @@ synchronized public ListConsumerGroupOffsetsResult 
listConsumerGroupOffsets(Map<
         String group = groupSpecs.keySet().iterator().next();
         Collection<TopicPartition> topicPartitions = 
groupSpecs.get(group).topicPartitions();
         final KafkaFutureImpl<Map<TopicPartition, OffsetAndMetadata>> future = 
new KafkaFutureImpl<>();
-
-        if (listConsumerGroupOffsetsException != null) {
-            future.completeExceptionally(listConsumerGroupOffsetsException);
+        if (topicPartitions.isEmpty()) {

Review Comment:
   Done, thanks for the suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to