[ https://issues.apache.org/jira/browse/KAFKA-7345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593885#comment-16593885 ]
John Roesler commented on KAFKA-7345: ------------------------------------- Thanks. I'll just respond on the PR. I wasn't sure which one you'd see first ;) > Potentially unclosed FileChannel in StateDirectory#unlock > --------------------------------------------------------- > > Key: KAFKA-7345 > URL: https://issues.apache.org/jira/browse/KAFKA-7345 > Project: Kafka > Issue Type: Bug > Components: streams > Reporter: Ted Yu > Priority: Minor > Attachments: KAFKA_7345.patch > > > {code} > lockAndOwner.lock.release(); > log.debug("{} Released state dir lock for task {}", logPrefix(), > taskId); > final FileChannel fileChannel = channels.remove(taskId); > if (fileChannel != null) { > fileChannel.close(); > {code} > If {{lockAndOwner.lock.release()}} throws IOE, the closing of the FileChannel > would be skipped. -- This message was sent by Atlassian JIRA (v7.6.3#76005)