lianetm commented on code in PR #16569:
URL: https://github.com/apache/kafka/pull/16569#discussion_r1681346936
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##########
@@ -78,14 +78,14 @@ public interface MembershipManager extends RequestManager {
/**
* Notify the member that an error heartbeat response was received.
*/
- void onHeartbeatFailure();
+ void onHeartbeatFailure(boolean retriable);
Review Comment:
the change is that `onHeartbeatFailure` is now called for all failures
(retriable and non-retriable), so seemed sensible to have a param indicating
the nature of the failure because different actions may be required depending
on it. It's not specific to metrics, even though that's the only action done
now on non-retriable.
I will add a param description here along the lines of "retriable -> True if
the heartbeat request failed with a retriable error". Nothing specific to the
metrics, it feels its very specific to the impl, and clear enough from it (and
would have to be maintained the moment we come add more action to the
`onHeartbeatFailure`), makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
