jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684708856


##########
raft/src/main/java/org/apache/kafka/raft/Endpoints.java:
##########
@@ -101,6 +102,21 @@ public 
BeginQuorumEpochRequestData.LeaderEndpointCollection toBeginQuorumEpochRe
         return leaderEndpoints;
     }
 
+    public AddRaftVoterRequestData.ListenerCollection toAddVoterRequest() {

Review Comment:
   I agree. There are many Endpoints methods that are not unittested. Do you 
mind if I tackle this in a future PR? 
https://issues.apache.org/jira/browse/KAFKA-17169



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to