chia7712 commented on code in PR #20281:
URL: https://github.com/apache/kafka/pull/20281#discussion_r2246062747
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaShareConsumer.java:
##########
@@ -497,7 +497,7 @@ public void acknowledge(ConsumerRecord<K, V> record) {
* <p>This method can only be used if the consumer is using <b>explicit
acknowledgement</b>.
*
* @param record The record to acknowledge
- * @param type The acknowledgement type which indicates whether it was
processed successfully
+ * @param type The acknowledge type which indicates whether it was
processed successfully
Review Comment:
if `acknowledge type` is a term used in shared consumer, could you please
consider fixing it in the codebase?
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetch.java#L113
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetch.java#L132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
