chia7712 commented on code in PR #20265:
URL: https://github.com/apache/kafka/pull/20265#discussion_r2296250817
##########
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java:
##########
@@ -182,12 +191,18 @@ public AssignmentsManager(
this.ready = new ConcurrentHashMap<>();
this.inflight = Map.of();
this.metricsRegistry = metricsRegistry;
-
this.metricsRegistry.newGauge(QUEUED_REPLICA_TO_DIR_ASSIGNMENTS_METRIC, new
Gauge<Integer>() {
+
this.metricsRegistry.newGauge(DEPRECATED_QUEUED_REPLICA_TO_DIR_ASSIGNMENTS_METRIC,
new Gauge<Integer>() {
@Override
Review Comment:
Please also fix the indent
##########
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java:
##########
@@ -90,10 +90,16 @@ public class RemoteStorageMetrics {
"kafka.server", "BrokerTopicMetrics", REMOTE_DELETE_LAG_SEGMENTS);
public static final MetricName
REMOTE_LOG_MANAGER_TASKS_AVG_IDLE_PERCENT_METRIC = getMetricName(
"kafka.log.remote", "RemoteLogManager",
REMOTE_LOG_MANAGER_TASKS_AVG_IDLE_PERCENT);
- public static final MetricName REMOTE_LOG_READER_TASK_QUEUE_SIZE_METRIC =
getMetricName(
+ @Deprecated(since = "4.2")
+ private static final MetricName
DEPRECATE_REMOTE_LOG_READER_TASK_QUEUE_SIZE_METRIC = getMetricName(
"org.apache.kafka.storage.internals.log",
"RemoteStorageThreadPool", REMOTE_LOG_READER_TASK_QUEUE_SIZE);
- public static final MetricName REMOTE_LOG_READER_AVG_IDLE_PERCENT_METRIC =
getMetricName(
+ @Deprecated(since = "4.2")
+ private static final MetricName
DEPRECATE_REMOTE_LOG_READER_AVG_IDLE_PERCENT_METRIC = getMetricName(
Review Comment:
Have you created the jira for the cleanup in 5.0? If not, please open one
##########
docs/upgrade.html:
##########
@@ -508,10 +509,6 @@ <h5><a id="upgrade_servers_400_notable"
href="#upgrade_servers_400_notable">Nota
<li> See <a
href="https://cwiki.apache.org/confluence/x/B40ODg";>KIP-890</a> and
<a
href="https://cwiki.apache.org/confluence/x/8ItyEg";>KIP-1050</a> for more
details </li>
</ul>
- <li>
- The filename for rotated <code>state-change.log</code>
files incorrectly rotates to <code>stage-change.log.[date]</code> (changing
state to stage). This issue is corrected in 4.0.1.
Review Comment:
why to remove this?
##########
docs/upgrade.html:
##########
@@ -110,9 +117,9 @@ <h5><a id="upgrade_410_notable"
href="#upgrade_410_notable">Notable changes in 4
</li>
</ul>
-<h4><a id="upgrade_4_0_1_from" href="#upgrade_4_0_1_from">Upgrading to
4.0.1</a></h4>
+<h4><a id="upgrade_4_0_0_from" href="#upgrade_4_0_0_from">Upgrading to
4.0.0</a></h4>
Review Comment:
ditto
##########
docs/upgrade.html:
##########
@@ -74,8 +83,6 @@ <h5><a id="upgrade_410_notable"
href="#upgrade_410_notable">Notable changes in 4
</li>
<li>
The KIP-966 part 1: Eligible Leader Replicas(ELR) will
be enabled by default on the new clusters.
- After the ELR feature enabled, the previously set
<code>min.insync.replicas</code> value at the broker-level config will be
removed.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
