AndrewJSchofield commented on code in PR #20746: URL: https://github.com/apache/kafka/pull/20746#discussion_r2451855252
########## server/src/main/java/org/apache/kafka/server/share/fetch/PartitionMaxBytesStrategy.java: ########## Review Comment: I think this could do with better commenting with regards to the parameters. For example, I think that `acquiredPartitionSize` can exceed `partitions.size()` indicating that the fetching is occurring for other partitions which are not being included in the current calculation. However, I suppose that `acquiredPartitionSize` should not be smaller than `partitions.size()`. Please can you tighten this up a bit since it's a slightly unusual interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
