AndrewJSchofield commented on code in PR #20746:
URL: https://github.com/apache/kafka/pull/20746#discussion_r2454598682
##########
server/src/main/java/org/apache/kafka/server/share/fetch/PartitionMaxBytesStrategy.java:
##########
@@ -43,6 +47,8 @@ public String toString() {
* @param partitions - The topic partitions in the order for which we
compute the partition max bytes.
* @param acquiredPartitionsSize - The total partitions that have been
acquired.
* @return the partition max bytes for the topic partitions
+ * The partitions passed for maxBytes calculation are a subset of total
acquired partitions for the share fetch request.
Review Comment:
nit: Let's put this above the parameters block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
