adixitconfluent commented on code in PR #20746:
URL: https://github.com/apache/kafka/pull/20746#discussion_r2464491056
##########
server/src/main/java/org/apache/kafka/server/share/fetch/PartitionMaxBytesStrategy.java:
##########
@@ -38,6 +44,8 @@ public String toString() {
/**
* Returns the partition max bytes for a given partition based on the
strategy type.
+ * The partitions passed for maxBytes calculation are a subset of total
acquired partitions for the share fetch request.
+ * Thus, partitions for which we want to compute the max bytes <= acquired
partitions.
Review Comment:
I think I can get rid of the line `Thus, partitions for which we want to
compute the max bytes <= acquired partitions.` The above line `The partitions
passed for maxBytes calculation can be a subset of total acquired partitions
for the share fetch request.` is self-explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
