lianetm commented on code in PR #20771: URL: https://github.com/apache/kafka/pull/20771#discussion_r2487542198
########## clients/src/main/java/org/apache/kafka/clients/admin/SharePartitionOffsetInfo.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.clients.admin; + +import org.apache.kafka.common.annotation.InterfaceStability; + +import java.util.Objects; +import java.util.Optional; + +/** + * This class is used to contain the offset and lag information for a share-partition. + */ [email protected] +public class SharePartitionOffsetInfo { + private final long startOffset; + private final Optional<Integer> leaderEpoch; + private final Optional<Long> lag; + + /** + * Construct a new StartPartitionOffsetInfo. Review Comment: ```suggestion * Construct a new SharePartitionOffsetInfo. ``` ########## clients/src/main/java/org/apache/kafka/clients/admin/SharePartitionOffsetInfo.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.clients.admin; + +import org.apache.kafka.common.annotation.InterfaceStability; + +import java.util.Objects; +import java.util.Optional; + +/** + * This class is used to contain the offset and lag information for a share-partition. + */ [email protected] +public class SharePartitionOffsetInfo { + private final long startOffset; + private final Optional<Integer> leaderEpoch; + private final Optional<Long> lag; + + /** + * Construct a new StartPartitionOffsetInfo. + * + * @param startOffset The share-partition start offset + * @param leaderEpoch The optional leader epoch of the start offset Review Comment: I expect this is the leader epoch of the share partition, correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
